linux-kernel - Re: commit 94fc5d9: chromium-sandbox core dumped

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFxU_n7yNmPKW=b135tf-rZ=pJzndjK6o+=6eshDCa8xAw@mail.gmail.com>
Date:	Mon, 19 Aug 2013 16:26:03 -0700
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Emmanuel Benisty <benisty.e@...il.com>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Richard Genoud <richard.genoud@...il.com>,
	Al Viro <viro@...iv.linux.org.uk>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: commit 94fc5d9: chromium-sandbox core dumped

On Mon, Aug 19, 2013 at 1:25 PM, Linus Torvalds
<torvalds@...ux-foundation.org> wrote:
>
> I suspect that last "return 0" at the end should be "return 1". Does
> that fix things for you? Untested.

Ok. Confirmed. I reproduced the bug that Richard Genoud fixed, and
also verified that yes, changing that last "return 0" in
proc_readdir_de() to "return 1" fixes the bug that Emmanuel reported.
Although I just did it with a special test-program using different
getdents buffer sizes, so I didn't verify the particular Chromium
breakage, but that does look like it's the same issue.

                    Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/