linux-kernel - Re: [PATCH 2/4] mfd: as3722: introduce core driver file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130820120311.GL23699@lee--X1>
Date:	Tue, 20 Aug 2013 13:03:11 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Florian Lobmaier <florian.lobmaier@....com>
Cc:	linux-kernel@...r.kernel.org, sameo@...ux.intel.com
Subject: Re: [PATCH 2/4] mfd: as3722: introduce core driver file

On Tue, 20 Aug 2013, Florian Lobmaier wrote:

> 
> Signed-off-by: Florian Lobmaier <florian.lobmaier@....com>
> ---
>  drivers/mfd/as3722-core.c |  747 +++++++++++++++++++++++++++++++++++++++++++++
>  1 files changed, 747 insertions(+), 0 deletions(-)
>  create mode 100644 drivers/mfd/as3722-core.c

This patch needs to be broken down quite a lot. First add the very
basic probe()ing and remove()ing code. Just enough to turn the device
on and do a version check etc.

Then in the next patch, allocate your resources, or a similar
activity. Then patch by patch, build it up do what it is now. Attempt
to add the headers at the appropriate times too. Although, if you
don't know what they all do, I won't be too stringent on that. Just
make sure that you don't add any regmap headers before you use any
regmap functionality, that kind of thing.

-- 
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/