linux-kernel - Re: [PATCH 3/4] mfd: as3722: introduce platform and register include files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130820120514.GM23699@lee--X1>
Date:	Tue, 20 Aug 2013 13:05:14 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Florian Lobmaier <florian.lobmaier@....com>
Cc:	linux-kernel@...r.kernel.org, sameo@...ux.intel.com
Subject: Re: [PATCH 3/4] mfd: as3722: introduce platform and register include
 files

On Tue, 20 Aug 2013, Florian Lobmaier wrote:

> 
> Signed-off-by: Florian Lobmaier <florian.lobmaier@....com>
> ---
>  include/linux/mfd/as3722-plat.h |  238 +++++++++++++++++++
>  include/linux/mfd/as3722-reg.h  |  495 +++++++++++++++++++++++++++++++++++++++
>  2 files changed, 733 insertions(+), 0 deletions(-)
>  create mode 100644 include/linux/mfd/as3722-plat.h
>  create mode 100644 include/linux/mfd/as3722-reg.h

Again, patches need to be orthogonal. If I were to apply patches 1 and
2, but leave out 3 and 4, it wouldn't build would it? You should add
these header files when you start referencing them from your *.c
files. At the very least, they should go in *before* you start to use
them.

-- 
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/