linux-kernel - Re: [PATCH 1/2] usb: fix cleanup after failure in hub

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1308201457380.892-100000@iolanthe.rowland.org>
Date:	Tue, 20 Aug 2013 14:59:18 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Krzysztof Mazur <krzysiek@...lesie.net>
cc:	linux-usb@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	<linux-kernel@...r.kernel.org>,
	Daniel J Blueman <daniel@...ascale-asia.com>
Subject: Re: [PATCH 1/2] usb: fix cleanup after failure in hub_configure()

On Tue, 20 Aug 2013, Krzysztof Mazur wrote:

> > Why bother with a separate jump label?  Just set maxchild to 0 whenever 
> > a failure occurs.
> > 
> 
> Initially I had just straightforward "dev->maxchild = 0;" after fail,
> but I changed that to simplify the second patch and be able to
> use goto fail:
> 
> 	ret = usb_hub_create_port_device(hub, i + 1);
> 	if (ret < 0) {
> 		dev_err(hub->intfdev,
> 			"couldn't create port%d device.\n", i + 1);
> 		hdev->maxchild = i;
> 		goto fail;
> 	}
> 
> and avoid "return ret" here or something like
> 
> 	if (hdev->maxchild == hub->descriptor->bNbrPorts)
> 		hdev->maxchild = 0;
> 
> in the fail path.

The second patch can either clean up the port devices by hand, or else 
jump to a new label after the line that sets maxchild to 0.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/