linux-kernel - Re: [PATCH 1/2] Revert "Revert "math64: New div64_u64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130820192508.GA4799@redhat.com>
Date:	Tue, 20 Aug 2013 15:25:08 -0400
From:	Mike Snitzer <snitzer@...hat.com>
To:	Ingo Molnar <mingo@...nel.org>
Cc:	Stanislaw Gruszka <sgruszka@...hat.com>, dm-devel@...hat.com,
	linux-kernel@...r.kernel.org,
	Mikulas Patocka <mpatocka@...hat.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	"Alasdair G. Kergon" <agk@...hat.com>
Subject: Re: [PATCH 1/2] Revert "Revert "math64: New div64_u64_rem helper""

On Tue, Aug 20 2013 at  4:09am -0400,
Ingo Molnar <mingo@...nel.org> wrote:

> 
> * Stanislaw Gruszka <sgruszka@...hat.com> wrote:
> 
> > On Fri, Aug 09, 2013 at 03:56:03PM -0400, Mike Snitzer wrote:
> > > This reverts commit f3002134158092178be81339ec5a22ff80e6c308.
> > > 
> > > div64_u64_rem was removed because there were no other users.
> > > 
> > > But Device Mapper's I/O statistics support has a need for
> > > div64_u64_rem; reintroduce this helper.
> > 
> > This slows down div64_u64 operation, especially on 32-bit 
> > systems.
> > 
> > Since dm statistic code is possibly not performance 
> > critical perhaps you could use something like below 
> > instead to calculate remainder:
> > 
> > res = div64_u64(a, b);
> > rem = a - b*res;
> 
> Or introduce a separately named helper without touching the 
> existing methods.

Thanks for the feedback.

I've pushed "math64: New separate div64_u64_rem helper" to the DM tree's
'for-next' branch:
https://git.kernel.org/cgit/linux/kernel/git/device-mapper/linux-dm.git/commit/?h=for-next&id=20e8125736d0e96b64c9b6127241d2a13529180a

Are you OK with me carrying this patch in the DM tree for 3.12
inclusion?

Mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/