linux-kernel - Re: [PATCH] nouveau: fix reclocking on nv40

Open Source and information security mailing list archives

Message-ID: <CACAvsv5a5JVZa=yFi7zy=zpHtFBCig+K8n-G9LOHN1vnKr94Dg@mail.gmail.com>
Date:	Wed, 21 Aug 2013 10:24:01 +1000
From:	Ben Skeggs <skeggsb@...il.com>
To:	Pali Rohár <pali.rohar@...il.com>
Cc:	Ben Skeggs <bskeggs@...hat.com>,
	Martin Peres <martin.peres@...ri.fr>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>
Subject: Re: [PATCH] nouveau: fix reclocking on nv40

On Mon, Aug 19, 2013 at 4:59 PM, Pali Rohár <pali.rohar@...il.com> wrote:
> On Friday 16 August 2013 14:57:07 Pali Rohár wrote:
>> In commit 77145f1cbdf8d28b46ff8070ca749bad821e0774 was
>> introduced error which cause that reclocking on nv40 not
>> working anymore. There is missing assigment of return value
>> from pll_calc to ret.
>>
>> Signed-off-by: Pali Rohár <pali.rohar@...il.com>
>> Signed-off-by: Martin Peres <martin.peres@...ri.fr>
>> ---
>>  drivers/gpu/drm/nouveau/nv40_pm.c |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/nouveau/nv40_pm.c
>> b/drivers/gpu/drm/nouveau/nv40_pm.c index 3af5bcd..625f80d
>> 100644
>> --- a/drivers/gpu/drm/nouveau/nv40_pm.c
>> +++ b/drivers/gpu/drm/nouveau/nv40_pm.c
>> @@ -131,7 +131,7 @@ nv40_calc_pll(struct drm_device *dev, u32
>> reg, struct nvbios_pll *pll, if (clk < pll->vco1.max_freq)
>>               pll->vco2.max_freq = 0;
>>
>> -     pclk->pll_calc(pclk, pll, clk, &coef);
>> +     ret = pclk->pll_calc(pclk, pll, clk, &coef);
>>       if (ret == 0)
>>               return -ERANGE;
>
> Hello, it is possible to include this patch in 3.11?
> Or it is too late now and need to wait for 3.12?
I've picked up the patch and will submit it in my next 3.11-fixes pull request.

Thanks,
Ben.

>
> --
> Pali Rohár
> pali.rohar@...il.com
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives