linux-kernel - RE: [patch] mm, thp: count thp_fault

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.02.1308211516290.6225@chino.kir.corp.google.com>
Date:	Wed, 21 Aug 2013 15:16:52 -0700 (PDT)
From:	David Rientjes <rientjes@...gle.com>
To:	"Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>
cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Mel Gorman <mgorman@...e.de>,
	Andrea Arcangeli <aarcange@...hat.com>,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: RE: [patch] mm, thp: count thp_fault_fallback anytime thp fault
 fails

On Wed, 21 Aug 2013, Kirill A. Shutemov wrote:

> David Rientjes wrote:
> > Currently, thp_fault_fallback in vmstat only gets incremented if a
> > hugepage allocation fails.  If current's memcg hits its limit or the page
> > fault handler returns an error, it is incorrectly accounted as a
> > successful thp_fault_alloc.
> > 
> > Count thp_fault_fallback anytime the page fault handler falls back to
> > using regular pages and only count thp_fault_alloc when a hugepage has
> > actually been faulted.
> > 
> > Signed-off-by: David Rientjes <rientjes@...gle.com>
> 
> It's probably a good idea, but please make the behaviour consistent in
> do_huge_pmd_wp_page() and collapse path, otherwise it doesn't make sense.
> 

The collapse path has no fallback, the allocation either succeeds or it 
fails.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/