linux-kernel - Re: [PATCH 4/4] pinctrl: mvebu: add missing iounmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130822132207.GA27167@localhost>
Date:	Thu, 22 Aug 2013 10:22:08 -0300
From:	Ezequiel Garcia <ezequiel.garcia@...e-electrons.com>
To:	Jisheng Zhang <jszhang@...vell.com>
Cc:	jason@...edaemon.net, andrew@...n.ch,
	gregory.clement@...e-electrons.com,
	thomas.petazzoni@...e-electrons.com, mturquette@...aro.org,
	sebastian.hesselbarth@...il.com, linus.walleij@...aro.org,
	linux@....linux.org.uk, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/4] pinctrl: mvebu: add missing iounmap

Hi Jisheng,

On Thu, Aug 22, 2013 at 08:46:51PM +0800, Jisheng Zhang wrote:
> Add missing iounmap to prove error path and remove path
> 
> Signed-off-by: Jisheng Zhang <jszhang@...vell.com>
> ---
>  drivers/pinctrl/mvebu/pinctrl-mvebu.c | 24 +++++++++++++++++-------
>  1 file changed, 17 insertions(+), 7 deletions(-)

How about using devm_ioremap_resource() instead?

-- 
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/