linux-kernel - Re: [PATCH 3/4] clk: mvebu: add missing iounmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130822223140.8231.74026@quantum>
Date:	Thu, 22 Aug 2013 15:31:40 -0700
From:	Mike Turquette <mturquette@...aro.org>
To:	Jisheng Zhang <jszhang@...vell.com>, <jszhang@...vell.com>,
	<jason@...edaemon.net>, <andrew@...n.ch>,
	<gregory.clement@...e-electrons.com>,
	<thomas.petazzoni@...e-electrons.com>,
	<ezequiel.garcia@...e-electrons.com>,
	<sebastian.hesselbarth@...il.com>, <linus.walleij@...aro.org>
Cc:	<linux@....linux.org.uk>, <linux-arm-kernel@...ts.infradead.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/4] clk: mvebu: add missing iounmap

Quoting Jisheng Zhang (2013-08-22 05:46:50)
> Add missing iounmap to setup error path.
> 
> Signed-off-by: Jisheng Zhang <jszhang@...vell.com>

Patch looks good with one minor nitpick below.

> @@ -145,10 +147,8 @@ void __init mvebu_clk_gating_setup(struct device_node *np,
>         ctrl->num_gates = n;
>         ctrl->gates = kzalloc(ctrl->num_gates * sizeof(struct clk *),
>                               GFP_KERNEL);
> -       if (WARN_ON(!ctrl->gates)) {
> -               kfree(ctrl);
> -               return;
> -       }
> +       if (WARN_ON(!ctrl->gates))
> +               goto bail_out;
>  
>         for (n = 0; n < ctrl->num_gates; n++) {
>                 const char *parent =
> @@ -160,4 +160,10 @@ void __init mvebu_clk_gating_setup(struct device_node *np,
>         }
>  
>         of_clk_add_provider(np, clk_gating_get_src, ctrl);
> +
> +       return;
> +bail_out:
> +       kfree(ctrl);
> +ctrl_out:
> +       iounmap(base);

bail_out is not the best name. How about gates_out?

Regards,
Mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/