linux-kernel - Re: [PATCH 3/3] raid6/test: replace echo -e with printf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d44b178f-0c43-483d-80f5-9791573bc526@email.android.com>
Date:	Thu, 22 Aug 2013 17:09:11 +0200
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Max Filippov <jcmvbkbc@...il.com>, linux-kernel@...r.kernel.org
CC:	Sam Ravnborg <sam@...nborg.org>,
	Guenter Roeck <linux@...ck-us.net>, NeilBrown <neilb@...e.de>,
	Jim Kukunas <james.t.kukunas@...ux.intel.com>,
	Yuanhan Liu <yuanhan.liu@...ux.intel.com>
Subject: Re: [PATCH 3/3] raid6/test: replace echo -e with printf

Acked-by: H. Peter Anvin <hpa@...or.com>

Max Filippov <jcmvbkbc@...il.com> wrote:
>-e is a non-standard echo option, echo output is
>implementation-dependent when it is used. Replace echo -e with printf
>as
>suggested by POSIX echo manual.
>
>Cc: NeilBrown <neilb@...e.de>
>Cc: Jim Kukunas <james.t.kukunas@...ux.intel.com>
>Cc: "H. Peter Anvin" <hpa@...or.com>
>Cc: Yuanhan Liu <yuanhan.liu@...ux.intel.com>
>Signed-off-by: Max Filippov <jcmvbkbc@...il.com>
>---
> lib/raid6/test/Makefile |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/lib/raid6/test/Makefile b/lib/raid6/test/Makefile
>index 087332d..73b0151 100644
>--- a/lib/raid6/test/Makefile
>+++ b/lib/raid6/test/Makefile
>@@ -28,7 +28,7 @@ ifeq ($(IS_X86),yes)
>                     gcc -c -x assembler - >&/dev/null &&	\
>                     rm ./-.o && echo -DCONFIG_AS_AVX2=1)
> else
>-        HAS_ALTIVEC := $(shell echo -e '\#include <altivec.h>\nvector
>int a;' |\
>+        HAS_ALTIVEC := $(shell printf '\#include <altivec.h>\nvector
>int a;\n' |\
>                          gcc -c -x c - >&/dev/null && \
>                          rm ./-.o && echo yes)
>         ifeq ($(HAS_ALTIVEC),yes)

-- 
Sent from my mobile phone. Please excuse brevity and lack of formatting.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/