linux-kernel - Re: [PATCH 2/3] x86: don't use echo -e needlessly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 22 Aug 2013 17:11:22 +0200
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Max Filippov <jcmvbkbc@...il.com>, linux-kernel@...r.kernel.org
CC:	Sam Ravnborg <sam@...nborg.org>,
	Guenter Roeck <linux@...ck-us.net>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>, x86@...nel.org
Subject: Re: [PATCH 2/3] x86: don't use echo -e needlessly

Can we drop the /bin/?

Max Filippov <jcmvbkbc@...il.com> wrote:
>-e is not needed to output strings without escape sequences.
>
>Cc: Thomas Gleixner <tglx@...utronix.de>
>Cc: Ingo Molnar <mingo@...hat.com>
>Cc: "H. Peter Anvin" <hpa@...or.com>
>Cc: x86@...nel.org
>Signed-off-by: Max Filippov <jcmvbkbc@...il.com>
>---
> arch/x86/Makefile |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/arch/x86/Makefile b/arch/x86/Makefile
>index 07639c6..7386e8a 100644
>--- a/arch/x86/Makefile
>+++ b/arch/x86/Makefile
>@@ -95,7 +95,7 @@ endif
> 
> ifdef CONFIG_X86_X32
> 	x32_ld_ok := $(call try-run,\
>-			/bin/echo -e '1: .quad 1b' | \
>+			/bin/echo '1: .quad 1b' | \
> 			$(CC) $(KBUILD_AFLAGS) -c -x assembler -o "$$TMP" - && \
> 			$(OBJCOPY) -O elf32-x86-64 "$$TMP" "$$TMPO" && \
> 			$(LD) -m elf32_x86_64 "$$TMPO" -o "$$TMP",y,n)

-- 
Sent from my mobile phone. Please excuse brevity and lack of formatting.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/