linux-kernel - Re: [PATCH] kvm tools: powerpc: Fix init order for xics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOJsxLH_Mp=sp4kC04Ov2zYpZE6hU8abwxuxwai=V5pqBHCsVA@mail.gmail.com>
Date:	Tue, 27 Aug 2013 14:52:32 +0300
From:	Pekka Enberg <penberg@...nel.org>
To:	Michael Neuling <mikey@...ling.org>
Cc:	KVM General <kvm@...r.kernel.org>, kvm-ppc@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>,
	Michael Ellerman <michael@...erman.id.au>,
	Ian Munsie <ianmunsi@....ibm.com>
Subject: Re: [PATCH] kvm tools: powerpc: Fix init order for xics

On Tue, Aug 20, 2013 at 6:28 AM, Michael Neuling <mikey@...ling.org> wrote:
> xics_init() assumes kvm->nrcpus is already setup.  kvm->nrcpus is setup
> in kvm_cpu_init()
>
> Unfortunately xics_init() and kvm_cpu_init() both use base_init().  So
> depending on the order randomly determined by the compiler, xics_init()
> may initialised see kvm->nrcpus as 0 and not setup any of the icp VCPU
> pointers.  This manifests itself later in boot when trying to raise an
> IRQ resulting in a null pointer deference/segv.
>
> This moves xics_init() to use dev_base_init() to ensure it happens after
> kvm_cpu_init().
>
> Signed-off-by: Michael Neuling <mikey@...ling.org>

Applied, thanks a lot!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/