linux-kernel - Re: [PATCH] epoll: add a reschedule point in ep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130827233300.GA14061@dcvr.yhbt.net>
Date:	Tue, 27 Aug 2013 23:33:00 +0000
From:	Eric Wong <normalperson@...t.net>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Al Viro <viro@...IV.linux.org.uk>, edumazet@...gle.com,
	Theodore Ts'o <tytso@....edu>
Subject: Re: [PATCH] epoll: add a reschedule point in ep_free()

Eric Dumazet <eric.dumazet@...il.com> wrote:
> From: Eric Dumazet <edumazet@...gle.com>
> 
> ep_free() might iterate on a huge set of epitems and hold
> cpu too long. Add two cond_resched() in order to yield cpu
> to other tasks. This is safe as we only hold mutexes in
> this function.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: Al Viro <viro@...IV.linux.org.uk>
> Cc: Theodore Ts'o <tytso@....edu>

Seems reasonable.  This isn't a remotely hot path and f_op->release
runs in a workqueue nowadays (right?).

Acked-by: Eric Wong <normalperson@...t.net>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/