linux-kernel - Re: [PATCH 08/24] Staging: winbond: reg: changed sleep function from msleep to usleep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130827233832.GA25985@kroah.com>
Date:	Tue, 27 Aug 2013 16:38:32 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Iker Pedrosa <ikerpedrosam@...il.com>
Cc:	pavel@....cz, justinmattock@...il.com, harsh1kumar@...il.com,
	dan.carpenter@...cle.com, mujeeb.adil@...il.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 08/24] Staging: winbond: reg: changed sleep function from
 msleep to usleep

On Mon, Aug 26, 2013 at 05:10:07PM +0200, Iker Pedrosa wrote:
> According to the documentation it is not recommended to use msleep for 1ms - 20ms because it may sleep longer than 20ms. So, it is recommended to use usleep instead.
> 
> Signed-off-by: Iker Pedrosa <ikerpedrosam@...il.com>
> ---
>  drivers/staging/winbond/reg.c | 52 +++++++++++++++++++++----------------------
>  1 file changed, 26 insertions(+), 26 deletions(-)
> 
> diff --git a/drivers/staging/winbond/reg.c b/drivers/staging/winbond/reg.c
> index 80b4b34..61916f5 100644
> --- a/drivers/staging/winbond/reg.c
> +++ b/drivers/staging/winbond/reg.c
> @@ -890,9 +890,9 @@ void Uxx_power_on_procedure(struct hw_data *pHwData)
>  	else {
>  		Wb35Reg_WriteSync(pHwData, 0x03f4, 0xFF5807FF);
>  		Wb35Reg_WriteSync(pHwData, 0x03d4, 0x80); /* regulator on only */
> -		msleep(10);
> +		usleep(10000);

This breaks the build :(

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/