linux-kernel - Re: [PATCH 20/24] Staging: winbond: wb35tx: changed sleep function from msleep to usleep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 27 Aug 2013 16:38:38 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Iker Pedrosa <ikerpedrosam@...il.com>
Cc:	pavel@....cz, devel@...verdev.osuosl.org, harsh1kumar@...il.com,
	linux-kernel@...r.kernel.org, mujeeb.adil@...il.com,
	justinmattock@...il.com, dan.carpenter@...cle.com
Subject: Re: [PATCH 20/24] Staging: winbond: wb35tx: changed sleep function
 from msleep to usleep

On Mon, Aug 26, 2013 at 05:10:19PM +0200, Iker Pedrosa wrote:
> According to the documentation it is not recommended to use msleep for 1ms - 20ms because it may sleep longer than 20ms. So, it is recommended to use usleep instead.
> 
> Signed-off-by: Iker Pedrosa <ikerpedrosam@...il.com>
> ---
>  drivers/staging/winbond/wb35tx.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/winbond/wb35tx.c b/drivers/staging/winbond/wb35tx.c
> index 30a77cc..8c25cbd 100644
> --- a/drivers/staging/winbond/wb35tx.c
> +++ b/drivers/staging/winbond/wb35tx.c
> @@ -166,9 +166,9 @@ void Wb35Tx_destroy(struct hw_data *pHwData)
>  
>  	/* Wait for VM stop */
>  	do {
> -		msleep(10); /* Delay for waiting function enter 940623.1.a */
> +		usleep(10000); /* Delay for waiting function enter 940623.1.a */

It looks like you didn't try to build this patch, as it breaks the build
for me here :(

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/