linux-kernel - Re: [PATCH 33/35] power: use dev_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <002801cea45d$8331b5f0$899521d0$%han@samsung.com>
Date:	Thu, 29 Aug 2013 11:14:37 +0900
From:	Jingoo Han <jg1.han@...sung.com>
To:	'Anton Vorontsov' <anton@...msg.org>
Cc:	'Dan Carpenter' <dan.carpenter@...cle.com>,
	'David Woodhouse' <dwmw2@...radead.org>,
	linux-kernel@...r.kernel.org, 'Joe Perches' <joe@...ches.com>,
	'Greg Kroah-Hartman' <gregkh@...uxfoundation.org>,
	'Andrew Morton' <akpm@...ux-foundation.org>,
	'Mark Brown' <broonie@...nel.org>,
	'Jingoo Han' <jg1.han@...sung.com>
Subject: Re: [PATCH 33/35] power: use dev_get_platdata()

On Thursday, August 29, 2013 10:19 AM, Anton Vorontsov wrote:
> On Wed, Aug 28, 2013 at 11:36:30AM +0300, Dan Carpenter wrote:
> > He doesn't want to take the patch.  He's the maintainer so it's his
> > choice.  That's the end of the story.
> 
> Just to clarify: I don't want to take the patch for a reason, not just
> because of my mood today. Once the patch comes in combination with another
> patch (or a plan) that actually makes use of the wrapper function, then
> I'd happily apply/ack it.

Sorry, I cannot understand.
This patch is a just cosmetic change.
I cannot understand why you reject it.

> 
> This is the same story as global checkpatch.pl fixes: they are more harm
> than good, and without the actual use of the dev_get_platdata(), the patch
> falls into "global checkpatch.pl fixes" category.

So, what is the harm of the fix using dev_get_platdata() wrapper function?
What is "the actual use of the dev_get_platdata()"?
Please, give me more detailed description.


Best regards,
Jingoo Han

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/