linux-kernel - Re: [PATCH 1/3 v3] pinctrl: ADI PIN control driver for the GPIO controller on bf54x and bf60x.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdbYB175wXYscP4Z=FQe7r9EzLoM+V+tWMK9YpNPFqH1wg@mail.gmail.com>
Date:	Fri, 30 Aug 2013 10:40:51 +0200
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Sonic Zhang <sonic.adi@...il.com>
Cc:	Stephen Warren <swarren@...dotorg.org>,
	Grant Likely <grant.likely@...aro.org>,
	Steven Miao <realmz6@...il.com>,
	LKML <linux-kernel@...r.kernel.org>,
	adi-buildroot-devel@...ts.sourceforge.net,
	Sonic Zhang <sonic.zhang@...log.com>
Subject: Re: [PATCH 1/3 v3] pinctrl: ADI PIN control driver for the GPIO
 controller on bf54x and bf60x.

On Thu, Aug 29, 2013 at 11:31 AM, Sonic Zhang <sonic.adi@...il.com> wrote:
> On Thu, Aug 29, 2013 at 4:12 PM, Linus Walleij <linus.walleij@...aro.org> wrote:

>> This is similar to the situation in the pinctrl-nomadik.c driver,
>> where the pinctrl portions wait for the GPIO devices to instantiate
>> before proceeding to probe "on top" of the GPIO blocks, using
>> the latter to get to the registers.
>>
>> I am not sure we have found the best way to sort out this
>> type of system, let's see what we can come up with.
>
> In the blackfin pinctrol-adi2 driver, I probe all gpio devices
> independently after all logic pinctrl devices. When one gpio device is
> probed, it can get its pinctrl device name from its platform data and
> add its gpio range into the pinctrl device via
> gpiochip_add_pin_range(). The gpio device don't need to know anything
> else about its pinctrl device.

This is ideal in the situation when there is a clear separation
between the GPIO and pin control (muxing, biasing)
registers. So you're doing the right thing.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/