linux-kernel - Re: linux-next: build warning after merge of the tip tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130830185546.69a289c2bef2173cc1ededf4@canb.auug.org.au>
Date:	Fri, 30 Aug 2013 18:55:46 +1000
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Ingo Molnar <mingo@...nel.org>
Cc:	Andi Kleen <andi@...stfloor.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...e.hu>, "H. Peter Anvin" <hpa@...or.com>,
	Peter Zijlstra <peterz@...radead.org>,
	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
	Andi Kleen <ak@...ux.intel.com>
Subject: Re: linux-next: build warning after merge of the tip tree

Hi all,

On Tue, 20 Aug 2013 08:42:09 +0200 Ingo Molnar <mingo@...nel.org> wrote:
>
> * Andi Kleen <andi@...stfloor.org> wrote:
> 
> > > > Introduced by commit 9a55fdbe941e ("x86, asmlinkage, paravirt: Add
> > > > __visible/asmlinkage to xen paravirt ops").  The 2 definitions used to be
> > > > identical ... maybe there should be only one.
> > > 
> > > Andi, please send a fix for this build warning, against 
> > > tip:x86/asmlinkage.
> > 
> > I resent the patch. Thanks for the headsup.
> 
> I suspect hpa missed it because the patch was opaque and 
> non-descriptive: the title talks about a 'warning' that is 
> supposedly fixed but the changelog does not explain what 
> warning it is and why the change matters.
> 
> Please use the customary changelog style we use in the 
> kernel:
> 
>   " Current code does (A), this has a problem when (B).
>     We can improve this doing (C), because (D)."
> 
> I've seen this pattern of deficient changelogs a dozen 
> times in your patches this year alone ...

Ping?

-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au

Content of type "application/pgp-signature" skipped