linux-kernel - [Question]: about the paramters of func generic_file_buffered

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Fri, 30 Aug 2013 17:14:47 +0800
From:	majianpeng <majianpeng@...il.com>
To:	viro <viro@...iv.linux.org.uk>
Cc:	linux-fsdevel <linux-fsdevel@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: [Question]: about the paramters of func generic_file_buffered_write.

Hi all,
	The definition of func generic_file_buffered_write is:
 		ssize_t generic_file_buffered_write(struct kiocb *, const struct iovec *,
                							unsigned long, loff_t, loff_t *, size_t, ssize_t);
The fourth and fifth paratmers indicate the current pos of file.
Every place which call this function, it set the fourth to iocb->ki_pos(maybe not but equal).
The fifth parameter is set &iocb->ki_pos.

I think we can remove two parameters. Those parameter can replace by the files of struct kiocb in the fun
of generic_file_buffered_write.

Or am i missing something?

Thansk!
Jianpeng Ma