linux-kernel - Re: [RFC,v3] Add a driver for the Somagic smi2021 chip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20130902065637.GA22726@server.arpanet.local>
Date:	Mon, 2 Sep 2013 08:56:37 +0200
From:	Jon Arne Jørgensen <jonarne@...arne.no>
To:	Wang Shilong <wangshilong1991@...il.com>
Cc:	Jon Arne Jørgensen <jonarne@...arne.no>,
	linux-kernel@...r.kernel.org, lkundrak@...sk, mkrufky@...uxtv.org,
	hans.verkuil@...co.com, rdunlap@...radead.org
Subject: Re: [RFC,v3] Add a driver for the Somagic smi2021 chip

On Mon, Sep 02, 2013 at 03:50:14AM +0800, Wang Shilong wrote:
Hi,
> Hello, Using checkpatch.pl, i get the following warnings(errors):
> WARNING: Avoid CamelCase: <udev->descriptor.idProduct>
> #1766: FILE: drivers/media/usb/smi2021/smi2021_main.c:790:
> +	if (udev->descriptor.idProduct == BOOTLOADER_ID)
> 
> total: 0 errors, 1 warnings, 2110 lines checked
> 
> patch has style problems, please review.
> 
That problem lies within the usb-subsystem.

When I ran checkpatch.pl on the patch before submitting this didn't show up.
Are you using an old version of checkpatch.pl?

> If any of these errors are false positives, please report
> them to the maintainer, see CHECKPATCH in MAINTAINERS.
> 
> Thanks, Wang
> 
> Notice: this is an automatically generated by shell script
> Any problems please contact: wangshilong1991@...il.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/