linux-kernel - Re: [PATCH 2/2] dma: k3dma: use devm_ioremap_resource() instead of devm_request_and

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5223F855.8070503@linaro.org>
Date:	Mon, 02 Sep 2013 10:30:45 +0800
From:	zhangfei <zhangfei.gao@...aro.org>
To:	Jingoo Han <jg1.han@...sung.com>
CC:	'Vinod Koul' <vinod.koul@...el.com>, 'Dan Williams' <djbw@...com>,
	linux-kernel@...r.kernel.org, 'Kai Yang' <jean.yangkai@...wei.com>
Subject: Re: [PATCH 2/2] dma: k3dma: use devm_ioremap_resource() instead of
 devm_request_and_ioremap()

On 13-09-02 09:26 AM, Jingoo Han wrote:
> Use devm_ioremap_resource() because devm_request_and_ioremap() is
> obsoleted by devm_ioremap_resource().
>
> Signed-off-by: Jingoo Han <jg1.han@...sung.com>

Thanks Jingoo for point out.

Acked-by: Zhangfei Gao <zhangfei.gao@...aro.org>

> ---
>   drivers/dma/k3dma.c |    6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/dma/k3dma.c b/drivers/dma/k3dma.c
> index ef7bc85..a2c330f 100644
> --- a/drivers/dma/k3dma.c
> +++ b/drivers/dma/k3dma.c
> @@ -673,9 +673,9 @@ static int k3_dma_probe(struct platform_device *op)
>   	if (!d)
>   		return -ENOMEM;
>
> -	d->base = devm_request_and_ioremap(&op->dev, iores);
> -	if (!d->base)
> -		return -EADDRNOTAVAIL;
> +	d->base = devm_ioremap_resource(&op->dev, iores);
> +	if (IS_ERR(d->base))
> +		return PTR_ERR(d->base);
>
>   	of_id = of_match_device(k3_pdma_dt_ids, &op->dev);
>   	if (of_id) {
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/