linux-kernel - Re: [PATCH] input: allow SERIO=m even without EXPERT=y

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAG-2HqX62iR_2fyFGAdTavL43EVLQ=cAoEArfKCkTVmxaEWQuw@mail.gmail.com>
Date:	Mon, 2 Sep 2013 23:46:00 +0200
From:	Tom Gundersen <teg@...m.no>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	richard -rw- weinberger <richard.weinberger@...il.com>,
	"linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>
Subject: Re: [PATCH] input: allow SERIO=m even without EXPERT=y

On Mon, Sep 2, 2013 at 11:30 PM, Geert Uytterhoeven
<geert@...ux-m68k.org> wrote:
> On Mon, Sep 2, 2013 at 11:01 PM, richard -rw- weinberger
> <richard.weinberger@...il.com> wrote:
>> On Mon, Sep 2, 2013 at 8:47 PM, Tom Gundersen <teg@...m.no> wrote:
>>> There is plenty of consumer hardware (e.g., mac books) that does not use
>>> AT keyboards or PS/2 mice. It therefore makes sense for distro kernels
>>> to build the related drivers as modules to avoid loading them on hardware
>>> that does not need them. As such, these options should no longer be protected
>>> by EXPERT.
>>>
>>> Moreover, building these drivers as modules gets rid of the following ugly
>>> error during boot:
>>>
>>> [    2.337745] i8042: PNP: No PS/2 controller found. Probing ports directly.
>>> [    3.439537] i8042: No controller found
>>>
>>> Signed-off-by: Tom Gundersen <teg@...m.no>
>>> Cc: Dmitry Torokhov <dmitry.torokhov@...il.com>
>>> ---
>>>  drivers/input/keyboard/Kconfig | 4 ++--
>>>  drivers/input/serio/Kconfig    | 6 +++---
>>>  2 files changed, 5 insertions(+), 5 deletions(-)
>>>
>>> diff --git a/drivers/input/keyboard/Kconfig b/drivers/input/keyboard/Kconfig
>>> index 269d4c3..2d31cec 100644
>>> --- a/drivers/input/keyboard/Kconfig
>>> +++ b/drivers/input/keyboard/Kconfig
>>> @@ -2,7 +2,7 @@
>>>  # Input core configuration
>>>  #
>>>  menuconfig INPUT_KEYBOARD
>>> -       bool "Keyboards" if EXPERT || !X86
>>> +       bool "Keyboards"
>>
>> Maybe this a stupid question, but why are you dropping the "!X86" too?
>
> Because the "if EXPERT" only mattered for X86.
>
> Apply De Morgan and it read like "do not ask the question if !EXPERT && X86".

Precisely.

-t
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/