linux-kernel - Re: [PATCH v3 0/3] cleanup of gpio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87a9jvsofz.wl%kuninori.morimoto.gx@renesas.com>
Date:	Sun, 01 Sep 2013 23:55:00 -0700 (PDT)
From:	Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
To:	George Cherian <george.cherian@...com>
Cc:	linus.walleij@...aro.org, linux-gpio@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-omap@...r.kernel.org,
	n.a.balandin@...il.com
Subject: Re: [PATCH v3 0/3] cleanup of gpio_pcf857x.c


Hi

Sorry for my many response.

> This patch series
>         - removes the irq_demux_work
>         - Uses devm_request_threaded_irq
>         - Call the user handler iff gpio_to_irq is done.
> 
> v1 --> v2
>         Split v1 to 3 patches
> v2 --> v3
> 	Remove the unnecessary dts patches.
> 
> 
> George Cherian (3):
>   gpio: pcf857x: change to devm_request_threaded_irq
>   gpio: pcf857x: remove the irq_demux_work
>   gpio: pcf857x: call the gpio user handler iff gpio_to_irq is done
> 
>  drivers/gpio/gpio-pcf857x.c | 51 +++++++++++++++++++++++----------------------
>  1 file changed, 26 insertions(+), 25 deletions(-)

Basically, I have no objection about these patches,
but I have 2 opinions
 - I guess we can merge #1 and #2 patches ?
   ("as is" is very OK for me though)
 - we don't need gpio->irq any more ?
   (additional patch is very OK for me)

Best regards
---
Kuninori Morimoto
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/