linux-kernel - [PATCH] x86, tsc: downgrade fast calibration failure message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1378217395-1241-1-git-send-email-jerome.oufella@savoirfairelinux.com>
Date:	Tue,  3 Sep 2013 10:09:55 -0400
From:	Jerome Oufella <jerome.oufella@...oirfairelinux.com>
To:	"H. Peter Anvin" <hpa@...or.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>
Cc:	<x86@...nel.org>, linux-kernel@...r.kernel.org,
	Paul Bolle <pebolle@...cali.nl>, kernel@...oirfairelinux.com,
	Jerome Oufella <jerome.oufella@...oirfairelinux.com>
Subject: [PATCH] x86, tsc: downgrade fast calibration failure message

As pointed out by Paul Bolle in https://lkml.org/lkml/2012/9/24/221, the
fast TSC calibration method may fail on some machines and result in an
error level message that does not reflect the severity of the case.

Signed-off-by: Jerome Oufella <jerome.oufella@...oirfairelinux.com>
---
This patch lost momentum and wordsmithing the message was evoked in
subsequent posts but imho reducing the level does the job just fine.
---
 arch/x86/kernel/tsc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c
index 6ff4924..e518724 100644
--- a/arch/x86/kernel/tsc.c
+++ b/arch/x86/kernel/tsc.c
@@ -380,7 +380,7 @@ static unsigned long quick_pit_calibrate(void)
 			goto success;
 		}
 	}
-	pr_err("Fast TSC calibration failed\n");
+	pr_info("Fast TSC calibration failed\n");
 	return 0;
 
 success:
-- 
1.8.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/