linux-kernel - Re: [PATCH] x86, tsc: downgrade fast calibration failure message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1378218699.1279.7.camel@x61.thuisdomein>
Date:	Tue, 03 Sep 2013 16:31:39 +0200
From:	Paul Bolle <pebolle@...cali.nl>
To:	Jerome Oufella <jerome.oufella@...oirfairelinux.com>
Cc:	"H. Peter Anvin" <hpa@...or.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>, x86@...nel.org,
	linux-kernel@...r.kernel.org, kernel@...oirfairelinux.com
Subject: Re: [PATCH] x86, tsc: downgrade fast calibration failure message

On Tue, 2013-09-03 at 10:09 -0400, Jerome Oufella wrote:
> As pointed out by Paul Bolle in https://lkml.org/lkml/2012/9/24/221, the
> fast TSC calibration method may fail on some machines and result in an
> error level message that does not reflect the severity of the case.
> 
> Signed-off-by: Jerome Oufella <jerome.oufella@...oirfairelinux.com>
> ---
> This patch lost momentum and wordsmithing the message was evoked in
> subsequent posts but imho reducing the level does the job just fine.

I've carried an identical patch locally ever since I submitted the patch
referenced by Jerome. Ie, I'm now running v3.11 with that patch applied.
Jerome's commit explanation is a bit terse when compared to my
verbosity, but otherwise I'm fine with this. So:

Acked-by: Paul Bolle <pebolle@...cali.nl>


Paul Bolle
> ---
>  arch/x86/kernel/tsc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c
> index 6ff4924..e518724 100644
> --- a/arch/x86/kernel/tsc.c
> +++ b/arch/x86/kernel/tsc.c
> @@ -380,7 +380,7 @@ static unsigned long quick_pit_calibrate(void)
>  			goto success;
>  		}
>  	}
> -	pr_err("Fast TSC calibration failed\n");
> +	pr_info("Fast TSC calibration failed\n");
>  	return 0;
>  
>  success:

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/