linux-kernel - Re: [PATCH] of_irq.h: fix build warnings when CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52266E43.70102@infradead.org>
Date:	Tue, 03 Sep 2013 16:18:27 -0700
From:	Randy Dunlap <rdunlap@...radead.org>
To:	Rob Herring <robherring2@...il.com>
CC:	LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Grant Likely <grant.likely@...aro.org>,
	Rob Herring <rob.herring@...xeda.com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [PATCH] of_irq.h: fix build warnings when CONFIG_OF is not enabled

On 09/03/13 15:31, Rob Herring wrote:
> On Mon, Sep 2, 2013 at 10:54 AM, Randy Dunlap <rdunlap@...radead.org> wrote:
>> From: Randy Dunlap <rdunlap@...radead.org>
>>
>> Fix build warnings when CONFIG_OF is not enabled:
> 
> It would be nice to know what arch/config you see this on.

i386 and x86_64.

> 
>> include/linux/of_irq.h:82:7: warning: 'struct device_node' declared inside parameter list [enabled by default]
>> include/linux/of_irq.h:82:7: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]
>> include/linux/of_irq.h:87:47: warning: 'struct device_node' declared inside parameter list [enabled by default]
>>
>> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
>> Cc:     Grant Likely <grant.likely@...aro.org>
>> Cc:     Rob Herring <rob.herring@...xeda.com>
>> Cc:     devicetree@...r.kernel.org
>> ---
>>  include/linux/of_irq.h |    2 ++
>>  1 file changed, 2 insertions(+)
>>
>> --- linux-next-20130830.orig/include/linux/of_irq.h
>> +++ linux-next-20130830/include/linux/of_irq.h
>> @@ -78,6 +78,8 @@ extern void of_irq_init(const struct of_
>>  #endif /* CONFIG_OF_IRQ */
>>
>>  #else /* !CONFIG_OF */
>> +struct device_node;
> 
> Can you move this outside of the ifdefs to minimize the amount of ifdef'ed code.

I'm build testing that change now, but it seems odd to have it there in 2 ways
when CONFIG_OF is enabled:


struct device_node;

#if defined(CONFIG_OF)

#include <linux/of.h>



will resend the patch shortly.

-- 
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/