linux-kernel - Re: [PATCH v7 1/4] spinlock: A new lockref structure for lockless update of refcount

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 4 Sep 2013 01:20:14 +0200
From:	Sedat Dilek <sedat.dilek@...il.com>
To:	Dave Jones <davej@...hat.com>, Sedat Dilek <sedat.dilek@...il.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Waiman Long <waiman.long@...com>,
	Ingo Molnar <mingo@...nel.org>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Alexander Viro <viro@...iv.linux.org.uk>,
	Jeff Layton <jlayton@...hat.com>,
	Miklos Szeredi <mszeredi@...e.cz>,
	Ingo Molnar <mingo@...hat.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	linux-fsdevel <linux-fsdevel@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Steven Rostedt <rostedt@...dmis.org>,
	Andi Kleen <andi@...stfloor.org>,
	"Chandramouleeswaran, Aswin" <aswin@...com>,
	"Norton, Scott J" <scott.norton@...com>
Subject: Re: [PATCH v7 1/4] spinlock: A new lockref structure for lockless
 update of refcount

On Wed, Sep 4, 2013 at 1:15 AM, Dave Jones <davej@...hat.com> wrote:
> On Wed, Sep 04, 2013 at 01:05:38AM +0200, Sedat Dilek wrote:
>  > On Wed, Sep 4, 2013 at 12:55 AM, Dave Jones <davej@...hat.com> wrote:
>  > > On Wed, Sep 04, 2013 at 12:37:25AM +0200, Sedat Dilek wrote:
>  > >
>  > >  > > You're spending more time on the task stats than on the actual lookup.
>  > >  > > Maybe you should turn off CONFIG_TASKSTATS..But why that whole
>  > >  > > irq_return thing? Odd.
>  > >  > >
>  > >  >
>  > >  > [ init/Kconfig ]
>  > >  > ...
>  > >  > config TASKSTATS
>  > >  >         bool "Export task/process statistics through netlink"
>  > >  >         depends on NET <--- Difficult to disable it?!
>  > >
>  > > More likely you're getting bitten by the fact that CONFIG_KVM has
>  > > a 'select TASKSTATS'
>  > >
>  >
>  > With CONFIG_KVM=n ...
>  >
>  > $ egrep 'CONFIG_NET=|CONFIG_KVM=|CONFIG_TASKSTATS' .config
>  > CONFIG_TASKSTATS=y
>  > CONFIG_NET=y
>
> Weird.
>
> sed -i '/TASKSTATS/d' .config
> sed -i '/KVM/d' .config
> make oldconfig
> ...
> egrep 'CONFIG_NET=|CONFIG_KVM=|CONFIG_TASKSTATS' .config
> # CONFIG_TASKSTATS is not set
> CONFIG_NET=y
>
>
> The NET dependancy shouldn't matter at all.
> I don't see any other 'select TASKSTATS' in the tree.
>

Ah, cool.

With CONFIG_KVM=n and CONFIG_TASKSTATS=n plus...

$ yes "" | make oldconfig && make silentoldconfig </dev/null

...I get now:

$ egrep 'CONFIG_NET=|CONFIG_KVM=|CONFIG_TASKSTATS' .config
# CONFIG_TASKSTATS is not set
CONFIG_NET=y

Thanks, Dave!

- Sedat -
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/