linux-kernel - Re: [PATCH 7/7] regulator: ti-abb: Use devm_regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130904151241.GB10849@sirena.org.uk>
Date:	Wed, 4 Sep 2013 16:12:41 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Nishanth Menon <nm@...com>
Cc:	Sachin Kamat <sachin.kamat@...aro.org>,
	linux-kernel@...r.kernel.org, ldewangan@...dia.com,
	gg@...mlogic.co.uk, yong.shen@...aro.org, s.hauer@...gutronix.de,
	marek.vasut@...il.com, Nancy.Chen@...escale.com
Subject: Re: [PATCH 7/7] regulator: ti-abb: Use devm_regulator_register

On Wed, Sep 04, 2013 at 08:27:56AM -0500, Nishanth Menon wrote:
> On 09/04/2013 01:31 AM, Sachin Kamat wrote:

> >  	abb = devm_kzalloc(dev, sizeof(struct ti_abb), GFP_KERNEL);
> > -	if (!abb) {
> > -		dev_err(dev, "%s: Unable to allocate ABB struct\n", __func__);
> > -		ret = -ENOMEM;
> > -		goto err;
> > -	}
> > +	if (!abb)
> > +		return -ENOMEM;

> here.

kzalloc() complains loudly when it fails, there's been a general thing
for removing the per-device logs as redundant.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)