linux-kernel - Re: [PATCH 5/7] regulator: palmas: Use devm_regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 4 Sep 2013 20:44:59 +0530
From:	Sachin Kamat <sachin.kamat@...aro.org>
To:	Marek Vasut <marex@...x.de>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Mark Brown <broonie@...nel.org>, nm@...com,
	Laxman Dewangan <ldewangan@...dia.com>, gg@...mlogic.co.uk,
	yong.shen@...aro.org, Sascha Hauer <s.hauer@...gutronix.de>,
	Nancy.Chen@...escale.com
Subject: Re: [PATCH 5/7] regulator: palmas: Use devm_regulator_register

On 4 September 2013 20:02, Marek Vasut <marex@...x.de> wrote:
> Dear Sachin Kamat,
>
>> devm_* simplifies the code.
>>
>> Signed-off-by: Sachin Kamat <sachin.kamat@...aro.org>
>> ---
>>  drivers/regulator/palmas-regulator.c |   38
>> @@ -1021,7 +1021,7 @@ static int palmas_regulators_probe(struct
>> platform_device *pdev) id, reg_init);
>>                               if (ret) {
>>                                       regulator_unregister(pmic->rdev[id]);
>> -                                     goto err_unregister_regulator;
>> +                                     return ret;
>>                               }
>
> what about this regulator_unregister() above here?

It should have gone too. I will send a fix for that. Thanks for noticing.



-- 
With warm regards,
Sachin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/