linux-kernel - Re: [PATCH 7/7] regulator: ti-abb: Use devm_regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52274E9F.4050708@ti.com>
Date:	Wed, 4 Sep 2013 10:15:43 -0500
From:	Nishanth Menon <nm@...com>
To:	Mark Brown <broonie@...nel.org>
CC:	Sachin Kamat <sachin.kamat@...aro.org>,
	<linux-kernel@...r.kernel.org>, <ldewangan@...dia.com>,
	<gg@...mlogic.co.uk>, <yong.shen@...aro.org>,
	<s.hauer@...gutronix.de>, <marek.vasut@...il.com>,
	<Nancy.Chen@...escale.com>
Subject: Re: [PATCH 7/7] regulator: ti-abb: Use devm_regulator_register

On 09/04/2013 10:12 AM, Mark Brown wrote:
> On Wed, Sep 04, 2013 at 08:27:56AM -0500, Nishanth Menon wrote:
>> On 09/04/2013 01:31 AM, Sachin Kamat wrote:
> 
>>>  	abb = devm_kzalloc(dev, sizeof(struct ti_abb), GFP_KERNEL);
>>> -	if (!abb) {
>>> -		dev_err(dev, "%s: Unable to allocate ABB struct\n", __func__);
>>> -		ret = -ENOMEM;
>>> -		goto err;
>>> -	}
>>> +	if (!abb)
>>> +		return -ENOMEM;
> 
>> here.
> 
> kzalloc() complains loudly when it fails, there's been a general thing
> for removing the per-device logs as redundant.
> 
True, but for the remaining, I do not thing it kind of helps to quiet
things up.

-- 
Regards,
Nishanth Menon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/