linux-kernel - Re: [PATCH 7/7] regulator: ti-abb: Use devm_regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK9yfHxyyZ8WGL8Q4cJ7Y=LcJ2dkeZamXydnMYS4uOj-cmU_Dg@mail.gmail.com>
Date:	Wed, 4 Sep 2013 21:56:49 +0530
From:	Sachin Kamat <sachin.kamat@...aro.org>
To:	Nishanth Menon <nm@...com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Mark Brown <broonie@...nel.org>,
	Laxman Dewangan <ldewangan@...dia.com>, gg@...mlogic.co.uk,
	yong.shen@...aro.org, Sascha Hauer <s.hauer@...gutronix.de>,
	marek.vasut@...il.com, Nancy.Chen@...escale.com
Subject: Re: [PATCH 7/7] regulator: ti-abb: Use devm_regulator_register

Hi  Nishanth,

On 4 September 2013 18:57, Nishanth Menon <nm@...com> wrote:
> On 09/04/2013 01:31 AM, Sachin Kamat wrote:
>> -err:
>> -     dev_err(dev, "%s: Failed to initialize(%d)\n", __func__, ret);
>> -     return ret;
> here -> with this, the lazy non detailed prints end with a generic
> fail case.

Generally when a driver is converted to use devm_* APIs, the error
handling code gets
refactored and simplified as several unwinding calls get removed. The
above print was similarly removed as part
of the cleanup and refactoring as it did not add any extra value.
Probe failure is reported even without this error
message.

-- 
With warm regards,
Sachin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/