linux-kernel - Re: [GIT PULL] Ext3, reiserfs, udf & isofs fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFytAMNADORn4FfUO620OvLdiMRNVhYbVuCFnWgo4kpvjQ@mail.gmail.com>
Date:	Fri, 6 Sep 2013 09:11:18 -0700
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Jan Kara <jack@...e.cz>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	linux-fsdevel <linux-fsdevel@...r.kernel.org>,
	"linux-ext4@...r.kernel.org" <linux-ext4@...r.kernel.org>
Subject: Re: [GIT PULL] Ext3, reiserfs, udf & isofs fixes

On Thu, Sep 5, 2013 at 12:58 PM, Jan Kara <jack@...e.cz> wrote:
>
> udf/isofs changes to refuse mounting fs rw instead of mounting it
> ro automatically which makes eject button work as expected for all media (see
> the changelog for why userspace should be ok with this change).

Pulled. However, these are kind of odd.

For trying _remount_ something read-only, isofs returns the logical
EROFS error code.

But for trying to mount it in the first place, it returns EACCES,
which sounds insane. It's not a permission problem - no amount of
permissions will ever make it work.

UDF always does EACCES, regardless of mount/remount.

Is there some fundamental reason for the insane error code? Does user
space do the wrong thing if we were to just always return "EROFS"
which makes much more sense?

                 Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/