linux-kernel - Re: kernel BUG at fs/dcache.c:648! with v3.11-7890-ge5c832d

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+55aFym_7gE5mpaWYkyLWuP-rAB3LnYgb4zmOw4M4bPjFoN1Q@mail.gmail.com>
Date:	Tue, 10 Sep 2013 12:27:27 -0700
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Al Viro <viro@...iv.linux.org.uk>
Cc:	Josh Boyer <jwboyer@...il.com>, Waiman Long <Waiman.Long@...com>,
	"Linux-Kernel@...r. Kernel. Org" <linux-kernel@...r.kernel.org>,
	Mace Moneta <moneta.mace@...il.com>
Subject: Re: kernel BUG at fs/dcache.c:648! with v3.11-7890-ge5c832d

On Tue, Sep 10, 2013 at 12:13 PM, Al Viro <viro@...iv.linux.org.uk> wrote:
>
> Ugh...  I really don't like that - your patch introduces the situations
> when race with chroot can lead to two absolute symlinks in the same path
> being interpreted wrt different roots.  And yes, sure, anybody who gets
> in that kind of races isn't going to get particulary sane results, but
> still, I'd rather have simpler semantics here...

Well, that "root is whatever it happens to be when we encounter the
slash" semantics is actually what we used to have before nameidata
anyway, so I don't actually believe it's anything new.

But I'll commit the simple patch that doesn't clean things up. I guess
we can always revisit this later (although I fear that once it all
works, we'll just leave it in the ugly state).

> Another thing: could you merge vfs.git#for-linus?  It's getting really
> messy to keep track of changes both in mainline and in vfs.git, especially
> since there's a pile of pending stuff (lru_list work) that needs to be
> resolved wrt both...

Will do. I was hoping to get this sorted out first.

              Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/