linux-kernel - Re: [PATCH] drivers: of: fix build break if asm/dma-contiguous.h is missing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <522F76CF.6080907@gmail.com>
Date:	Tue, 10 Sep 2013 14:45:19 -0500
From:	Rob Herring <robherring2@...il.com>
To:	Marek Szyprowski <m.szyprowski@...sung.com>
CC:	linux-kernel@...r.kernel.org, linaro-mm-sig@...ts.linaro.org,
	devicetree@...r.kernel.org,
	Kyungmin Park <kyungmin.park@...sung.com>,
	Arnd Bergmann <arnd@...db.de>,
	Michal Nazarewicz <mina86@...a86.com>,
	Grant Likely <grant.likely@...retlab.ca>,
	Tomasz Figa <t.figa@...sung.com>,
	Sylwester Nawrocki <s.nawrocki@...sung.com>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Laura Abbott <lauraa@...eaurora.org>,
	Olof Johansson <olof@...om.net>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Stephen Warren <swarren@...dotorg.org>,
	Ian Campbell <ian.campbell@...rix.com>,
	Tomasz Figa <tomasz.figa@...il.com>,
	Kumar Gala <galak@...eaurora.org>,
	Nishanth Peethambaran <nishanth.p@...il.com>,
	Marc <marc.ceeeee@...il.com>, Guenter Roeck <linux@...ck-us.net>
Subject: Re: [PATCH] drivers: of: fix build break if asm/dma-contiguous.h
 is missing

On 09/10/2013 04:13 AM, Marek Szyprowski wrote:
> It is not needed to include asm/dma-contiguous.h header to compile
> reserved memory initialization code, so remove it to avoid build break
> on architectures without CMA support.
> 
> Signed-off-by: Marek Szyprowski <m.szyprowski@...sung.com>

Acked-by: Rob Herring <rob.herring@...xeda.com>

I can apply this or it can go with other CMA stuff.

Aren't there also some comments from Grant to address as well?

Rob

> ---
>  drivers/of/of_reserved_mem.c |    2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/of/of_reserved_mem.c b/drivers/of/of_reserved_mem.c
> index a754b84..0fe40c7 100644
> --- a/drivers/of/of_reserved_mem.c
> +++ b/drivers/of/of_reserved_mem.c
> @@ -11,8 +11,6 @@
>   * License or (at your optional) any later version of the license.
>   */
>  
> -#include <asm/dma-contiguous.h>
> -
>  #include <linux/memblock.h>
>  #include <linux/err.h>
>  #include <linux/of.h>
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/