lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 12 Sep 2013 15:40:31 +0100 From: Mel Gorman <mgorman@...e.de> To: Hillf Danton <dhillf@...il.com> Cc: Peter Zijlstra <a.p.zijlstra@...llo.nl>, Rik van Riel <riel@...hat.com>, Srikar Dronamraju <srikar@...ux.vnet.ibm.com>, Ingo Molnar <mingo@...nel.org>, Andrea Arcangeli <aarcange@...hat.com>, Johannes Weiner <hannes@...xchg.org>, Linux-MM <linux-mm@...ck.org>, LKML <linux-kernel@...r.kernel.org> Subject: Re: [PATCH 41/50] sched: numa: Use {cpu, pid} to create task groups for shared faults On Thu, Sep 12, 2013 at 08:42:18PM +0800, Hillf Danton wrote: > Hello Mel > > On Tue, Sep 10, 2013 at 5:32 PM, Mel Gorman <mgorman@...e.de> wrote: > > > > +void task_numa_free(struct task_struct *p) > > +{ > > + struct numa_group *grp = p->numa_group; > > + int i; > > + > > + kfree(p->numa_faults); > > + > > + if (grp) { > > + for (i = 0; i < 2*nr_node_ids; i++) > > + atomic_long_sub(p->numa_faults[i], &grp->faults[i]); > > + > use after free, numa_faults ;/ > It gets fixed in the patch "sched: numa: use group fault statistics in numa placement" but I agree that it's the wrong place to fix it. -- Mel Gorman SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists