linux-kernel - Re: [PATCH v2] pstore: Adjust buffer size for compression for smaller registered buffers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5232145B.7070009@linux.vnet.ibm.com>
Date:	Fri, 13 Sep 2013 00:52:03 +0530
From:	Aruna Balakrishnaiah <aruna@...ux.vnet.ibm.com>
To:	"Luck, Tony" <tony.luck@...el.com>
CC:	"linuxppc-dev@...abs.org" <linuxppc-dev@...abs.org>,
	"seiji.aguchi@....com" <seiji.aguchi@....com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"keescook@...omium.org" <keescook@...omium.org>,
	"jkenisto@...ux.vnet.ibm.com" <jkenisto@...ux.vnet.ibm.com>,
	"mahesh@...ux.vnet.ibm.com" <mahesh@...ux.vnet.ibm.com>,
	"ccross@...roid.com" <ccross@...roid.com>,
	"cbouatmailru@...il.com" <cbouatmailru@...il.com>
Subject: Re: [PATCH v2] pstore: Adjust buffer size for compression for smaller
 registered buffers

On Thursday 12 September 2013 11:13 PM, Luck, Tony wrote:
> +	default:
> +		cmpr = 60;
> +		break;
> +	}
>
> Is this the right "default"?  It may be a good choice for a backend with a really
> tiny buffer (1 ... 999).  But less good for a (theoretical) backend with a larger
> buffer (10001 ... infinity and beyond).  Which are you trying to catch here?

Trying to catch lower buffers and also tried till 23k ( 10k * 100/45) of text with a
sample crash logit achieved a good compression of 25%. Since the upper limit is 
not known
and compression behavior is not tested above 10k chose to keep a higher default 
of 60.

> -Tony
>
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@...ts.ozlabs.org
> https://lists.ozlabs.org/listinfo/linuxppc-dev
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/