linux-kernel - Re: [PATCH] Kconfig cleanup (PARPORT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130912204904.GR12758@n2100.arm.linux.org.uk>
Date:	Thu, 12 Sep 2013 21:49:04 +0100
From:	Russell King - ARM Linux <linux@....linux.org.uk>
To:	Sam Ravnborg <sam@...nborg.org>
Cc:	Mark Salter <msalter@...hat.com>, linux-arch@...r.kernel.org,
	linux-kernel@...r.kernel.org, rth@...ddle.net, vgupta@...opsys.com,
	tony.luck@...el.com, geert@...ux-m68k.org, monstr@...str.eu,
	ralf@...ux-mips.org, jejb@...isc-linux.org,
	benh@...nel.crashing.org, lethal@...ux-sh.org, davem@...emloft.net,
	cmetcalf@...era.com, gxt@...c.pku.edu.cn, tglx@...utronix.de,
	mingo@...hat.com, hpa@...or.com
Subject: Re: [PATCH] Kconfig cleanup (PARPORT_PC dependencies)

On Thu, Sep 12, 2013 at 10:32:04PM +0200, Sam Ravnborg wrote:
> On Thu, Sep 12, 2013 at 02:53:58PM -0400, Mark Salter wrote:
> > Remove messy dependencies from PARPORT_PC by having it depend on one
> > Kconfig symbol (ARCH_MAY_HAVE_PC_PARPORT) and having architectures
> > which need it declare ARCH_MAY_HAVE_PC_PARPORT in arch/*/Kconfig.
> > New architectures are unlikely to need PARPORT_PC, so this avoids
> > having an ever growing list of architectures to exclude. Those
> > architectures which do declare ARCH_MAY_HAVE_PC_PARPORT in this
> > patch are the ones which have an asm/parport.h.
> 
> It is much nicer if you provide a config symbol only once.
> And then let the architectures who want it select this symbol.
> 
> This is the pattern we use for similar things in many places today,
> so it is best to follow that pattern.

Yes, and if you do, please be sensitive to the files you're editing.
If you find yourself adding a "select" statement at the bottom of an
already sorted list, then you're probably going to make someone less
than happy.

(I've just re-sorted arch/arm/Kconfig's select statements after they've
become mis-sorted - originally sorted alphabetically at akpm's request
to avoid conflicts.  It now has a comment at the end of the main list
asking for new additions to be appropriately placed.)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/