linux-kernel - Re: [PATCH] Kconfig cleanup (PARPORT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130912205349.GC3262@gmail.com>
Date:	Thu, 12 Sep 2013 22:53:49 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	"H. Peter Anvin" <hpa@...or.com>
Cc:	Mark Salter <msalter@...hat.com>, linux-arch@...r.kernel.org,
	linux-kernel@...r.kernel.org, rth@...ddle.net, vgupta@...opsys.com,
	linux@....linux.org.uk, tony.luck@...el.com, geert@...ux-m68k.org,
	monstr@...str.eu, ralf@...ux-mips.org, jejb@...isc-linux.org,
	benh@...nel.crashing.org, lethal@...ux-sh.org, davem@...emloft.net,
	cmetcalf@...era.com, gxt@...c.pku.edu.cn, tglx@...utronix.de,
	mingo@...hat.com
Subject: Re: [PATCH] Kconfig cleanup (PARPORT_PC dependencies)


* H. Peter Anvin <hpa@...or.com> wrote:

> On 09/12/2013 11:53 AM, Mark Salter wrote:
> >  
> > diff --git a/drivers/parport/Kconfig b/drivers/parport/Kconfig
> > index 70694ce..fa005a9 100644
> > --- a/drivers/parport/Kconfig
> > +++ b/drivers/parport/Kconfig
> > @@ -35,9 +35,7 @@ if PARPORT
> >  
> >  config PARPORT_PC
> >  	tristate "PC-style hardware"
> > -	depends on (!SPARC64 || PCI) && !SPARC32 && !M32R && !FRV && !S390 && \
> > -		(!M68K || ISA) && !MN10300 && !AVR32 && !BLACKFIN && \
> > -		!XTENSA && !CRIS && !H8300
> > +	depends on ARCH_MAY_HAVE_PC_PARPORT
> >  
> >  	---help---
> >  	  You should say Y here if you have a PC-style parallel port. All
> > 
> 
> I'm somewhat astonished that this driver is that problematic.  It is 
> really just a very basic PIO interface, at least in the absence of 
> EPP/ECP.
> 
> It is, of course, also largely a dead interface at this point so it 
> probably doesn't matter.

So, my collection of 'randconfig kernel crashers' has this exclusion and 
comment:

 --- linux.orig/drivers/block/Kconfig
 +++ linux/drivers/block/Kconfig
 @@ -77,6 +77,11 @@ config GDROM
  config PARIDE
         tristate "Parallel port IDE device support"
         depends on PARPORT_PC
 +
 +       # the probe can hang during bootup on non-PARIDE boxes
 +       depends on BROKEN_BOOT_ALLOWED
 +       select BROKEN_BOOT if PARIDE = y
 +

So at least some uses of PARPORT_PC are unsafe. (might easily be a bug in 
PARIDE)

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/