linux-kernel - Re: perf/compat: Sharpen the libaudit dependencies test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130914054906.GA364@gmail.com>
Date:	Sat, 14 Sep 2013 07:49:06 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>
Cc:	linux-tip-commits@...r.kernel.org, linux-kernel@...r.kernel.org,
	eranian@...gle.com, paulus@...ba.org, hpa@...or.com,
	peterz@...radead.org, efault@....de, fweisbec@...il.com,
	adrian.hunter@...el.com, dsahern@...il.com, tglx@...utronix.de
Subject: Re: perf/compat: Sharpen the libaudit dependencies test


* Arnaldo Carvalho de Melo <acme@...stprotocols.net> wrote:

> Em Thu, Sep 12, 2013 at 03:27:06PM +0200, Ingo Molnar escreveu:
> > There are older libaudit versions that don't have an audit_errno_to_name() 
> > method, resulting in a builtin-trace.c build error:
> > 
> >   builtin-trace.c: In function ‘trace__sys_exit’:
> >   builtin-trace.c:794: warning: implicit declaration of function ‘audit_errno_to_name’
> > 
> > Expand the libaudit test to detect this.
> 
> Lets sharpen it a bit more ;-)
>  
> CHK libaudit
> <stdin>: In function ‘main’:
> <stdin>:5:9: error: ‘error’ undeclared (first use in this function)
> <stdin>:5:9: note: each undeclared identifier is reported only once for each function it appears in
> <stdin>:5:15: error: expected ‘)’ before ‘message’
> make: Entering directory `/home/git/linux/tools/perf'
> config/Makefile:238: No libaudit.h found, disables 'trace' tool, please install audit-libs-devel or libaudit-dev
> 
> We need this folded in to buind it, so that the test works:
> 
> diff --git a/tools/perf/config/feature-tests.mak b/tools/perf/config/feature-tests.mak
> index 5608add..7f550c1 100644
> --- a/tools/perf/config/feature-tests.mak
> +++ b/tools/perf/config/feature-tests.mak
> @@ -210,7 +210,7 @@ define SOURCE_LIBAUDIT
>  
>  int main(void)
>  {
> -	printf("error message: %s\n", audit_errno_to_name(0));
> +	printf(\"error message: %s\n\", audit_errno_to_name(0));

indeed, I only tested that it turned the feature off :-/

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/