linux-kernel - Re: [PATCH] hung_task: change sysctl_hung_task_check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130914055359.GB364@gmail.com>
Date:	Sat, 14 Sep 2013 07:53:59 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Li Zefan <lizefan@...wei.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] hung_task: change sysctl_hung_task_check_count to int


* Li Zefan <lizefan@...wei.com> wrote:

> Cc: Ingo, as this touched include/linux/sched/.
> 
> On 2013/9/14 10:47, Li Zefan wrote:
> > As sysctl_hung_task_check_count is unsigned long, when this value is
> > assigned to max_count in check_hung_uninterruptible_tasks(), it's
> > truncated to int type.
> > 
> > Therefore if we write 2^32 to sysctl.hung_task_check_count, hung task
> > detection will be effectively disabled.
> > 
> > Not a big deal, but still it's better to fix this inconsistency.
> > 
> > Signed-off-by: Li Zefan <lizefan@...wei.com>
> > ---
> >  include/linux/sched/sysctl.h | 2 +-
> >  kernel/hung_task.c           | 2 +-
> >  kernel/sysctl.c              | 4 ++--
> >  3 files changed, 4 insertions(+), 4 deletions(-)
> > 
> > diff --git a/include/linux/sched/sysctl.h b/include/linux/sched/sysctl.h
> > index bf8086b..9552afa 100644
> > --- a/include/linux/sched/sysctl.h
> > +++ b/include/linux/sched/sysctl.h
> > @@ -2,8 +2,8 @@
> >  #define _SCHED_SYSCTL_H
> >  
> >  #ifdef CONFIG_DETECT_HUNG_TASK
> > +extern int	     sysctl_hung_task_check_count;
> >  extern unsigned int  sysctl_hung_task_panic;
> > -extern unsigned long sysctl_hung_task_check_count;
> >  extern unsigned long sysctl_hung_task_timeout_secs; extern unsigned 
> >  long sysctl_hung_task_warnings; extern int 
> >  proc_dohung_task_timeout_secs(struct ctl_table *table, int write,

Looks good, but I suppose most of the unsigned longs above ought to be 
downgraded to int as well?

Acked-by: Ingo Molnar <mingo@...nel.org>

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/