linux-kernel - Re: [PATCH] perf tools: Check libunwind for availability of dwarf parsing feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 14 Sep 2013 08:02:26 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Jean Pihet <jean.pihet@...aro.org>
Cc:	Will Deacon <will.deacon@....com>, Jiri Olsa <jolsa@...hat.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linaro-kernel@...ts.linaro.org" <linaro-kernel@...ts.linaro.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"patches@...aro.org" <patches@...aro.org>
Subject: Re: [PATCH] perf tools: Check libunwind for availability of dwarf
 parsing feature


* Jean Pihet <jean.pihet@...aro.org> wrote:

> Hi Will,
> 
> On 13 September 2013 19:15, Will Deacon <will.deacon@....com> wrote:
> > Hi Jean,
> >
> > On Fri, Sep 13, 2013 at 06:08:41PM +0100, Jean Pihet wrote:
> >> The newly added dwarf unwinding feature [1] requires:
> >> . a recent version (>= 1.1) of libunwind,
> >> . libunwind to be configured with --enable-debug-frame.
> >>
> >> [1] http://www.spinics.net/lists/kernel/msg1598951.html
> >>
> >> Add the corresponding API test in the feature check list.
> >
> > Any reason not to merge this in with the third patch in original series? I
> > don't think it's been picked up by anybody yet, so it would make sense to
> > repost with this fixup after the merge window.
>
> Yes you are right Will repost with this patch folded into the third 
> patch, or as a fourth patch. Any preference?

I suspect it should be a separate patch, but _prior_ the patch that makes 
use of this new facility.

That way it's bisection-safe.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/