linux-kernel - Re: [PATCH 1/4 v2] mfd: add STw481x driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130916104009.GA29403@sirena.org.uk>
Date:	Mon, 16 Sep 2013 11:40:09 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Lee Jones <lee.jones@...aro.org>
Cc:	Linus Walleij <linus.walleij@...aro.org>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	linux-kernel@...r.kernel.org,
	Wang Shilong <wangshilong1991@...il.com>
Subject: Re: [PATCH 1/4 v2] mfd: add STw481x driver

On Mon, Sep 16, 2013 at 10:19:56AM +0100, Lee Jones wrote:

> Can't you just NULL .id_table?

> Here's the code which would use it:
> > /* match on an id table if there is one */
> > if (driver->id_table)
> >         return i2c_match_id(driver->id_table, client) != NULL;

> Matching for "dummy" will just waste cycles.

i2c_device_probe() will return -ENODEV if id_table is NULL before we get
to actually matching.  We could remove that check though...

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)