linux-kernel - Re: [PATCH 14/38] iio: accel: st: Append _accel to accelerator sensor device names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 16 Sep 2013 14:03:04 +0200
From:	Lars-Peter Clausen <lars@...afoo.de>
To:	Denis CIOCCA <denis.ciocca@...com>
CC:	Jonathan Cameron <jic23@...nel.org>,
	Lee Jones <lee.jones@...aro.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"jic23@....ac.uk" <jic23@....ac.uk>,
	"arnd@...db.de" <arnd@...db.de>,
	"linus.walleij@...aro.org" <linus.walleij@...aro.org>,
	"linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>
Subject: Re: [PATCH 14/38] iio: accel: st: Append _accel to accelerator sensor
 device names

On 09/16/2013 11:21 AM, Denis CIOCCA wrote:
> Hi Lars,
>> On 09/14/2013 02:27 PM, Jonathan Cameron wrote:
>>> On 09/14/13 13:14, Jonathan Cameron wrote:
>>>> On 09/10/13 13:49, Lee Jones wrote:
>>>>> Some of ST's sensors are appended with their sensor type and some
>>>>> are not. For consistency we're extending the same naming convention
>>>>> throughout.
>>>>>
>>>>> Signed-off-by: Lee Jones <lee.jones@...aro.org>
>>>> Honestly I don't care either way on these, but consistency would definitely
>>>> be good so applied to the togreg branch of iio.git
>>>>
>>>> Thanks,
>>> Actually change of plan. I'm going to hold off on these as this an ABI change.
>>> Iritating though having these as completely inconsistent is, changing this
>>> will change device identification from userspace which is not a good idea.
>>>
>>> Sorry Lee, but we really shouldn't do this. I should have picked up on this
>>> in the original driver reviews but that's hindsight for you.
>> I think those with the suffix are the ones where you have accel and gyro in
>> the same package, the ones without the suffix are pure accelerometers.
> Yes You are right. I've used this kind of logic... What do you think about?
> 
> Denis

Seems sensible to me.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/