linux-kernel - Re: [PATCH] mfd: arizona: Update volatile registers for WM5110 DSP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130917072425.GP16984@lee--X1>
Date:	Tue, 17 Sep 2013 08:24:25 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
Cc:	sameo@...ux.intel.com, patches@...nsource.wolfsonmicro.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd: arizona: Update volatile registers for WM5110 DSP

On Mon, 16 Sep 2013, Charles Keepax wrote:

Any chance of a little more information in the commit message?

What are scratch registers and why are they required now where they
weren't before? Why are the control and clocking regulators no longer
needed?

> Signed-off-by: Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
> ---
>  drivers/mfd/wm5110-tables.c |   18 ++++++++++++++++--
>  1 files changed, 16 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mfd/wm5110-tables.c b/drivers/mfd/wm5110-tables.c
> index 2a79723..92c6ea6 100644
> --- a/drivers/mfd/wm5110-tables.c
> +++ b/drivers/mfd/wm5110-tables.c
> @@ -2334,20 +2334,34 @@ static bool wm5110_volatile_register(struct device *dev, unsigned int reg)
>  	case ARIZONA_AOD_IRQ2:
>  	case ARIZONA_ASRC_STATUS:
>  	case ARIZONA_DSP_STATUS:
> -	case ARIZONA_DSP1_CONTROL_1:
> -	case ARIZONA_DSP1_CLOCKING_1:
>  	case ARIZONA_DSP1_STATUS_1:
>  	case ARIZONA_DSP1_STATUS_2:
>  	case ARIZONA_DSP1_STATUS_3:
> +	case ARIZONA_DSP1_SCRATCH_0:
> +	case ARIZONA_DSP1_SCRATCH_1:
> +	case ARIZONA_DSP1_SCRATCH_2:
> +	case ARIZONA_DSP1_SCRATCH_3:
>  	case ARIZONA_DSP2_STATUS_1:
>  	case ARIZONA_DSP2_STATUS_2:
>  	case ARIZONA_DSP2_STATUS_3:
> +	case ARIZONA_DSP2_SCRATCH_0:
> +	case ARIZONA_DSP2_SCRATCH_1:
> +	case ARIZONA_DSP2_SCRATCH_2:
> +	case ARIZONA_DSP2_SCRATCH_3:
>  	case ARIZONA_DSP3_STATUS_1:
>  	case ARIZONA_DSP3_STATUS_2:
>  	case ARIZONA_DSP3_STATUS_3:
> +	case ARIZONA_DSP3_SCRATCH_0:
> +	case ARIZONA_DSP3_SCRATCH_1:
> +	case ARIZONA_DSP3_SCRATCH_2:
> +	case ARIZONA_DSP3_SCRATCH_3:
>  	case ARIZONA_DSP4_STATUS_1:
>  	case ARIZONA_DSP4_STATUS_2:
>  	case ARIZONA_DSP4_STATUS_3:
> +	case ARIZONA_DSP4_SCRATCH_0:
> +	case ARIZONA_DSP4_SCRATCH_1:
> +	case ARIZONA_DSP4_SCRATCH_2:
> +	case ARIZONA_DSP4_SCRATCH_3:
>  		return true;
>  	default:
>  		return false;

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/