linux-kernel - Re: [PATCH] Staging: bcm: PHSModule.c: Matching the function definition with function declaration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.02.1309171035000.2252@hadrien>
Date:	Tue, 17 Sep 2013 10:35:26 +0200 (CEST)
From:	Julia Lawall <julia.lawall@...6.fr>
To:	Shalin Mehta <shalinmehta85@...il.com>
cc:	gregkh@...uxfoundation.org, klmckinney1@...il.com,
	devel@...verdev.osuosl.org, kernel-janitors@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: bcm: PHSModule.c: Matching the function definition
 with function declaration

On Tue, 17 Sep 2013, Shalin Mehta wrote:

> From: Shalin Mehta <shalinmehta85@...il.com>
>
> NOTE: Sending it again. I got mail delivery failure due to typo in emai ID gregkh@...uxfoundation.org

I think that such a comment should go below the ---, since it doesn't have
to be preserved in git.

julia

>
>
> The function implementations of the PHSModule didn't match with the declaration. The functions are static
> in the declaration but in the implemntation they are non-static
>
> Signed-off-by: Shalin Mehta <shalinmehta85@...il.com>
> ---
>  drivers/staging/bcm/PHSModule.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/bcm/PHSModule.c b/drivers/staging/bcm/PHSModule.c
> index af5d22f..56c5bee 100644
> --- a/drivers/staging/bcm/PHSModule.c
> +++ b/drivers/staging/bcm/PHSModule.c
> @@ -596,7 +596,7 @@ ULONG PhsDeleteSFRules(IN void *pvContext, IN B_UINT16 uiVcid)
>   * 0 if successful,
>   * >0 Error.
>   */
> -ULONG PhsCompress(IN void *pvContext,
> +static ULONG PhsCompress(IN void *pvContext,
>  		IN B_UINT16 uiVcid,
>  		IN B_UINT16 uiClsId,
>  		IN void *pvInputBuffer,
> @@ -677,7 +677,7 @@ ULONG PhsCompress(IN void *pvContext,
>   * 0 if successful,
>   * >0 Error.
>   */
> -ULONG PhsDeCompress(IN void *pvContext,
> +static ULONG PhsDeCompress(IN void *pvContext,
>  		IN B_UINT16 uiVcid,
>  		IN void *pvInputBuffer,
>  		OUT void *pvOutputBuffer,
> @@ -829,7 +829,7 @@ UINT GetServiceFlowEntry(IN struct bcm_phs_table *psServiceFlowTable,
>  	return PHS_INVALID_TABLE_INDEX;
>  }
>
> -UINT GetClassifierEntry(IN struct bcm_phs_classifier_table *pstClassifierTable,
> +static UINT GetClassifierEntry(IN struct bcm_phs_classifier_table *pstClassifierTable,
>  			IN B_UINT32 uiClsid, enum bcm_phs_classifier_context eClsContext,
>  			OUT struct bcm_phs_classifier_entry **ppstClassifierEntry)
>  {
> @@ -880,7 +880,7 @@ static UINT GetPhsRuleEntry(IN struct bcm_phs_classifier_table *pstClassifierTab
>  	return PHS_INVALID_TABLE_INDEX;
>  }
>
> -UINT CreateSFToClassifierRuleMapping(IN B_UINT16 uiVcid, IN B_UINT16  uiClsId,
> +static UINT CreateSFToClassifierRuleMapping(IN B_UINT16 uiVcid, IN B_UINT16  uiClsId,
>  				IN struct bcm_phs_table *psServiceFlowTable,
>  				struct bcm_phs_rule *psPhsRule,
>  				B_UINT8 u8AssociatedPHSI)
> @@ -913,7 +913,7 @@ UINT CreateSFToClassifierRuleMapping(IN B_UINT16 uiVcid, IN B_UINT16  uiClsId,
>  	return uiStatus;
>  }
>
> -UINT CreateClassiferToPHSRuleMapping(IN B_UINT16 uiVcid,
> +static UINT CreateClassiferToPHSRuleMapping(IN B_UINT16 uiVcid,
>  				IN B_UINT16 uiClsId,
>  				IN struct bcm_phs_entry *pstServiceFlowEntry,
>  				struct bcm_phs_rule *psPhsRule,
> @@ -1239,7 +1239,7 @@ void DumpPhsRules(struct bcm_phs_extension *pDeviceExtension)
>   *			header.
>   *	0	-If PHS rule is NULL.If PHSI is 0 indicateing packet as uncompressed.
>   */
> -int phs_decompress(unsigned char *in_buf,
> +static int phs_decompress(unsigned char *in_buf,
>  		unsigned char *out_buf,
>  		struct bcm_phs_rule *decomp_phs_rules,
>  		UINT *header_size)
> --
> 1.8.1.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/