linux-kernel - Re: [PATCH 1/1] x86/iommu: correct ICS register offset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52381505.4010701@hp.com>
Date:	Tue, 17 Sep 2013 16:38:29 +0800
From:	ZhenHua <zhen-hual@...com>
To:	"Li, Zhen-Hua" <zhen-hual@...com>,
	David Woodhouse <dwmw2@...radead.org>,
	iommu@...ts.linux-foundation.org, linux-kernel@...r.kernel.org,
	Ingo Molnar <mingo@...nel.org>, Joerg Roedel <joro@...tes.org>,
	Donald Dutile <ddutile@...hat.com>
Subject: Re: [PATCH 1/1] x86/iommu: correct ICS register offset

Hi Guys,
     Though  DMAR_ICS_REG is not used yet, I think this patch is 
necessary. So please take a look at it.

Thanks
ZhenHua

On 09/13/2013 02:27 PM, Li, Zhen-Hua wrote:
> According to Intel Vt-D specs, the offset of Invalidation complete
> status register should be 0x9C, not 0x98.
>
> See Intel's VT-d spec, Revision 1.3, Chapter 10.4, Page 98;
>
> Signed-off-by: Li, Zhen-Hua <zhen-hual@...com>
> ---
>   include/linux/intel-iommu.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/intel-iommu.h b/include/linux/intel-iommu.h
> index 78e2ada..d380c5e 100644
> --- a/include/linux/intel-iommu.h
> +++ b/include/linux/intel-iommu.h
> @@ -55,7 +55,7 @@
>   #define DMAR_IQT_REG	0x88	/* Invalidation queue tail register */
>   #define DMAR_IQ_SHIFT	4	/* Invalidation queue head/tail shift */
>   #define DMAR_IQA_REG	0x90	/* Invalidation queue addr register */
> -#define DMAR_ICS_REG	0x98	/* Invalidation complete status register */
> +#define DMAR_ICS_REG	0x9c	/* Invalidation complete status register */
>   #define DMAR_IRTA_REG	0xb8    /* Interrupt remapping table addr register */
>
>   #define OFFSET_STRIDE		(9)
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/