lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 17 Sep 2013 16:29:04 +0200 From: Hannes Reinecke <hare@...e.de> To: Doug Ledford <dledford@...hat.com> Cc: Paul Gortmaker <paul.gortmaker@...driver.com>, linux-scsi list <linux-scsi@...r.kernel.org>, linux-kernel@...r.kernel.org, "James E.J. Bottomley" <JBottomley@...allels.com> Subject: Re: [PATCH] scsi: delete decade+ obsolete aic7xxx_old driver On 09/17/2013 04:13 AM, Doug Ledford wrote: > Yes, this driver is well past ready to be removed. > > Acked-by: Doug Ledford <dledford@...hat.com> > > Sent from my ASUS Pad > > Paul Gortmaker <paul.gortmaker@...driver.com> wrote: > >> After getting warnings in an allyesconfig build[1] from this >> driver, I decided to remind myself just how old it was, and >> whether it warranted fixing. In the Kconfig help text, I found: >> >> "This driver will eventually be phased out entirely" >> >> Going back to the history archive, I see the line was added[2] >> in Feb 2002, when we moved from v2.4.2.1 ---> v2.4.2.2 >> >> So, with over a decade of notification, and multiple major releases >> since then, I think we can justify removing this. Currently we have >> people wasting time building it during routine testing, and then >> wasting more time re-researching the known reported warnings, only to >> find that nobody really is willing to integrate the fixes[3] for it. >> >> A quick search didn't seem to indicate any active user base for it. >> If someone happens to have a quirky _old_ card that the eleven year >> old "new" driver doesn't work with, then it is entirely reasonable >> that they stick with a kernel version that predates this removal. >> >> [1] drivers/scsi/aic7xxx_old.c: In function ‘aic7xxx_register’: >> drivers/scsi/aic7xxx_old.c:7901:5: warning: case value ‘257’ not in enumerated type ‘ahc_chip’ [-Wswitch] >> drivers/scsi/aic7xxx_old.c:7898:5: warning: case value ‘513’ not in enumerated type ‘ahc_chip’ [-Wswitch] >> drivers/scsi/aic7xxx_old.c: In function ‘aic7xxx_load_seeprom’: >> drivers/scsi/aic7xxx_old.c:8517:5: warning: case value ‘257’ not in enumerated type ‘ahc_chip’ [-Wswitch] >> drivers/scsi/aic7xxx_old.c:8510:5: warning: case value ‘513’ not in enumerated type ‘ahc_chip’ [-Wswitch] >> >> [2] http://git.kernel.org/cgit/linux/kernel/git/tglx/history.git commit 44e8778c >> >> [3] https://lkml.org/lkml/2012/10/29/215 >> >> Cc: Hannes Reinecke <hare@...e.de> >> Cc: Doug Ledford <dledford@...hat.com> >> Cc: "James E.J. Bottomley" <JBottomley@...allels.com> >> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com> However, if we do this we're removing support for any non-PCI based adapters. I personally doubt that there are any installations left running on (E)ISA or VLB. But we should be clear on this. In general I'm in favour removing obsolete drivers, so Acked-by: Hannes Reinecke <hare@...e.de> Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@...e.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists