linux-kernel - Re: Fix style in s3c-hsotg.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130917220427.GC23937@amd.pavel.ucw.cz>
Date:	Wed, 18 Sep 2013 00:04:27 +0200
From:	Pavel Machek <pavel@....cz>
To:	Felipe Balbi <balbi@...com>
Cc:	kernel list <linux-kernel@...r.kernel.org>,
	linux-usb@...r.kernel.org
Subject: Re: Fix style in s3c-hsotg.c

On Tue 2013-09-17 10:42:30, Felipe Balbi wrote:
> Hi,
> 
> On Mon, Sep 02, 2013 at 03:58:32PM +0200, Pavel Machek wrote:
> > Hi!
> > 
> > checkpatch.pl has some valid complaints about style in s3c-hsotg.c :
> > macro with if should be really enclosed in do {} while, and puts is
> > going to be slightly faster.
> > 
> > Here's suggested patch. I don't have the hardware, so it is completely
> > untested.
> > 
> > Signed-off-by: Pavel Machek, <pavel@...x.de>
> 
> this is not how you send a patch, please read
> Documentation/SubmittingPatches

Have you considered possibility that this is how you nudge maintainer
into fix their coding style?

Thanks,
									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/