linux-kernel - Re: Fix style in s3c-hsotg.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130918014539.GB19817@radagast>
Date:	Tue, 17 Sep 2013 20:45:39 -0500
From:	Felipe Balbi <balbi@...com>
To:	Pavel Machek <pavel@....cz>
CC:	Felipe Balbi <balbi@...com>,
	kernel list <linux-kernel@...r.kernel.org>,
	<linux-usb@...r.kernel.org>
Subject: Re: Fix style in s3c-hsotg.c

On Wed, Sep 18, 2013 at 12:04:27AM +0200, Pavel Machek wrote:
> On Tue 2013-09-17 10:42:30, Felipe Balbi wrote:
> > Hi,
> > 
> > On Mon, Sep 02, 2013 at 03:58:32PM +0200, Pavel Machek wrote:
> > > Hi!
> > > 
> > > checkpatch.pl has some valid complaints about style in s3c-hsotg.c :
> > > macro with if should be really enclosed in do {} while, and puts is
> > > going to be slightly faster.
> > > 
> > > Here's suggested patch. I don't have the hardware, so it is completely
> > > untested.
> > > 
> > > Signed-off-by: Pavel Machek, <pavel@...x.de>
> > 
> > this is not how you send a patch, please read
> > Documentation/SubmittingPatches
> 
> Have you considered possibility that this is how you nudge maintainer
> into fix their coding style?

cute...

Seriously though, read that file, you're commit log has garbage in it
which shouldn't go to git history.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)