linux-kernel - Re: [PATCH 002/007] WAN Drivers: Update farsync driver and introduce fsflex driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1379517921.1787.24.camel@joe-AO722>
Date:	Wed, 18 Sep 2013 08:25:21 -0700
From:	Joe Perches <joe@...ches.com>
To:	Kevin Curtis <Kevin.Curtis@...site.com>
Cc:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
	Dermot Smith <dermot.smith@...site.com>
Subject: Re: [PATCH 002/007] WAN Drivers: Update farsync driver and
 introduce fsflex driver

On Wed, 2013-09-18 at 11:11 +0100, Kevin Curtis wrote:
> Farsite Communications FarSync driver update
[]
> diff -uprN -X linux-3.10.1/Documentation/dontdiff linux-3.10.1/drivers/net/wan/uss_cmn.h linux-3.10.1_new/drivers/net/wan/uss_cmn.h

> +typedef enum _USS_COMMANDS {

I think this code would be more linux style
without all the typedefs

> +typedef struct {
[]
> +} FLEX_SERCONF, *PFLEX_SERCONF;

> +typedef struct {
[]
> +} FLEX_CARD_INFO, *PFLEX_CARD_INFO;    /* sizeof(FLEX_CARD_INFO) = 128 */

> +typedef struct {
[]
> +} FLEX_USB_STATS, *PFLEX_USB_STATS;

> +typedef struct _INTERFACE_RECORD {
[]
> +} IR, *PIR;

> +typedef struct _INTERFACE_RECORD_EX {
[]
> +} IREX, *PIREX;


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/